Argus icon indicating copy to clipboard operation
Argus copied to clipboard

Make destination delete button use a modal

Open hmpf opened this issue 7 months ago • 3 comments

Scope and purpose

Fixes #1357, depends on #1358

Contributor Checklist

Every pull request should have this checklist filled out, no matter how small it is. More information about contributing to Argus can be found in the Development docs.

  • [x] Added a changelog fragment for towncrier
  • [x] Linted/formatted the code with ruff and djLint, easiest by using pre-commit
  • [x] The first line of the commit message continues the sentence "If applied, this commit will ...", starts with a capital letter, does not end with punctuation and is 50 characters or less long. See our how-to
  • [ ] If applicable: Created new issues if this PR does not fix the issue completely/there is further work to be done
  • [ ] If this results in changes in the UI: Added screenshots of the before and after

hmpf avatar Apr 04 '25 12:04 hmpf

Test results

   11 files  1 320 suites   49m 59s ⏱️   583 tests   582 ✅  1 💤 0 ❌ 6 413 runs  6 402 ✅ 11 💤 0 ❌

Results for commit 29697c34.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Apr 04 '25 12:04 github-actions[bot]

Codecov Report

Attention: Patch coverage is 34.61538% with 17 lines in your changes missing coverage. Please review.

Project coverage is 78.58%. Comparing base (b388959) to head (29697c3).

Files with missing lines Patch % Lines
src/argus/htmx/destination/views.py 41.17% 10 Missing :warning:
src/argus/notificationprofile/models.py 0.00% 7 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1359      +/-   ##
==========================================
- Coverage   78.74%   78.58%   -0.16%     
==========================================
  Files         142      142              
  Lines        5800     5814      +14     
==========================================
+ Hits         4567     4569       +2     
- Misses       1233     1245      +12     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov-commenter avatar Apr 04 '25 13:04 codecov-commenter