agda-unimath icon indicating copy to clipboard operation
agda-unimath copied to clipboard

Adding explicit zero algebras

Open djspacewhale opened this issue 1 year ago • 1 comments

Added initial work for the zero ring and zero abelian group, along with proofs of their uniqueness up to contractible type. Remaining work is refactoring for the rest of the zero algebras along the way and the final uniqueness proof by SIP.

djspacewhale avatar Mar 22 '24 21:03 djspacewhale

Awesome! Thanks for contributing to agda-unimath!

EgbertRijke avatar Mar 23 '24 12:03 EgbertRijke

It would be nice to have these changes merged soon, but we have suggested some changes that need to be addressed first. What is your status, @djspacewhale? If you prefer, I can take care of the finishing touches for you and merge this.

fredrik-bakke avatar Apr 06 '24 21:04 fredrik-bakke

Sorry for disappearing for a while there. I'll merge these today.

djspacewhale avatar Apr 09 '24 18:04 djspacewhale

Oh, judging from the "checks" below, it seems either one of your files is missing an import, or is-contr-subgroup-is-trivial-Group is called something else. Also, you will have to run our pre-commit hooks on your project to apply auto-formatting rules.

For a guide on how to set up pre-commit, see here:

  • https://unimath.github.io/agda-unimath/HOWTO-INSTALL.html#contributor-setup

To learn more about what it does, see here:

  • https://unimath.github.io/agda-unimath/CONTRIBUTING.html

fredrik-bakke avatar Apr 11 '24 09:04 fredrik-bakke

Let me know if you have any questions!

fredrik-bakke avatar Apr 11 '24 09:04 fredrik-bakke

Excellent! I will enable auto-merging now

fredrik-bakke avatar Apr 11 '24 20:04 fredrik-bakke