CuraEngine icon indicating copy to clipboard operation
CuraEngine copied to clipboard

Slicing with 0% support density does not terminate if the cross pattern is used.

Open ThomasRahm opened this issue 4 years ago • 4 comments

Application Version 4.7.1

Platform Windows 10

Steps to Reproduce Set Support Pattern to "cross" and Support Density to 0% with support enabled.

Actual Results The slicing never finishes.

Expected results The support should have no infill.

Additional Information Issue is that support line distance is set to 0 when the support density is 0. This causes the following loop of SierpinskiFillProvider.cpp (line 73) to never terminate:

coord_t aabb_size = min_line_distance;
while (aabb_size < max_side_length)
{
    aabb_size *= 2;
    depth += 2;
}

As aabb_size will be 0.

I am not sure how to fix this issue, without potentially adding a new one.

ThomasRahm avatar Feb 12 '21 15:02 ThomasRahm

Hi @ThomasRahm thank you for your report. I can also reproduce this in 4.8. I will discuss it with the team. Keep you posted!

fvrmr avatar Feb 18 '21 09:02 fvrmr

Hi @ThomasRahm I have discussed it with the team. But I have to defer this. Because it is really exceptional to run into this. So it is not a priority for us to fix. Hope you understand.

fvrmr avatar Feb 19 '21 11:02 fvrmr

Hi thomas, this is not a bug! I've talked about your mod, maybe you are interested! https://community.ultimaker.com/topic/40567-cura-tree-support-mod-ts2/ Have a good day

lospo avatar May 23 '22 10:05 lospo

@lospo Great to hear that you like it, but this is the wrong place for it.
If you want to give feedback here on github, please use the draft pull-request thread for it.
Also you may want to edit your message, as i interpreted "This is not a bug" as disagreeing regarding the bug reported above and that the slicing to hang is intentional.

ThomasRahm avatar May 23 '22 21:05 ThomasRahm