Move to having two reviewers for pull requests?

[dstansby]

What needs to be done?

Now we have a pretty established package and set of docs, I was wondering what people think of going up from requiring one approval to two approvals on pull requests? My thinking is that:

• It would give a second pair of eyes on stuff to make sure anything we add to the docs has slightly wider agreement
• Getting other folks to review/approve changes or additions to the docs might be a nice low-effort/low barrier to entry way of getting more people involved in this project?

It would slow down how fast things are merged, but I think that the project as a whole is now mature enough that that shouldn't be too much of an issue.

Thoughts?

[paddyroddy]

I like this idea. However, I very rarely miss a notification, which may not be the case for others. Being blocked when you have a 1 review and awaiting a 2nd can be frustrating.

[samcunliffe]

I'm 👍 to this idea. Two members or associate members?

Perhaps after we've tagged "v1" of our template and the repo is citable, etc...?