Tyson Williams

Results 381 comments of Tyson Williams
trafficstars

Nvm. I now see you did that on purpose.

Which commit in this PR requires the changes in the first commit?

Can you make a PR before this one that adds `ofNull` and `toNull` for `ValueOption` along with some tests containing examples with data on which they could be called?

I want to see how `toNull` and `ofNull` in `ValueOption` are used. Specifically, I want to see a use case where `toNull` returns `Error`. Can this happen with both a...

Quoting https://github.com/elmish/Elmish.WPF/pull/470#issuecomment-1160492351 > However, it's possible that we could reintroduce those changes just with `id` instead of `box`. I think I prefer that. Can you make that change?

Can you squash the commit with message > [Add some tests for binding vm helpers](https://github.com/elmish/Elmish.WPF/pull/470/commits/b1834960cb76acf165e7ccddc1ae188abbdec2f8) into the commit that adds the code being tested? Can you also squash the commit...

For each comment that had a pin put in it, can you add a comment on the new PR that is adding that code, link back to the pinned comment...

> I have implemented something I would have thought should work, but there are obvious problems with it. Perhaps somebody can have a look. It's a very simple example. I...

> Maybe I should have asked first if there are already samples somewhere that solves what I'm trying to do. > ... > Multiselect is such an important and central...