BlockNote icon indicating copy to clipboard operation
BlockNote copied to clipboard

fix: dev-script failing in windows issue

Open rogueloop opened this issue 1 year ago • 2 comments

fix: npm run gen fails in windows due to file path issues.

close /955 /claim /955

https://github.com/user-attachments/assets/2aab5573-0505-45f2-b2a9-be0ed5fc37e7

rogueloop avatar Jul 29 '24 22:07 rogueloop

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
blocknote ✅ Ready (Inspect) Visit Preview Jul 30, 2024 6:44pm

vercel[bot] avatar Jul 29 '24 22:07 vercel[bot]

Someone is attempting to deploy a commit to the TypeCell Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Jul 29 '24 22:07 vercel[bot]

I just tested it on both Windows 10 and MacOS and here are the current results

OS Updates examples.gen.tsx Generates example files
Windows
MacOS

By "Generates example files" I mean the package.json, tsconfig.json, index.html, main.tsx, and vite.config.ts in each example folder that should be automatically generated by the script.

Note: I copied the above text from my response to the other PR about the same issue because it's actually the same case scenario.

zaaakher avatar Jul 30 '24 10:07 zaaakher

https://github.com/user-attachments/assets/9c7cc844-3578-491e-b849-3a92183f460a

Addressed the issues @zaaakher

rogueloop avatar Jul 30 '24 18:07 rogueloop

@rogueloop I just tested again and it's working well just as expected 👍

OS Updates examples.gen.tsx Generates example files
Windows
MacOS

zaaakher avatar Jul 30 '24 18:07 zaaakher

Ready for a review @YousefED

rogueloop avatar Jul 31 '24 06:07 rogueloop