BlockNote icon indicating copy to clipboard operation
BlockNote copied to clipboard

Emoji item in slash menu does nothing

Open danielrearden opened this issue 1 year ago • 4 comments

Describe the bug Nothing happens when clicking the emoji item in the slash menu. That's because when calling editor.openSelectionMenu, we still consider the minQueryLength passed to GridSuggestionMenuController. Setting this value to 0 makes calling editor.openSelectionMenu behave as expected, but is not desirable because now the minQueryLength is not enforced when you type :.

To Reproduce

  • Go to https://www.blocknotejs.org
  • Open the slash menu
  • Select the emoji item

Misc

  • Node version: 22.4.1
  • Package manager: pnpm
  • Browser: Chrome
  • [ ] I'm a sponsor and would appreciate if you could look into this sooner than later 💖

danielrearden avatar Jul 24 '24 21:07 danielrearden

Same, emojies aren’t working

ats1999 avatar Jul 25 '24 04:07 ats1999

FWIW, Notion does not actually open the suggestions menu for this action. Instead, it just inserts a :, which seems like a cleaner experience anyway.

danielrearden avatar Jul 28 '24 15:07 danielrearden

Hey, any updates on this? Do you guys need help?

danlupascu avatar Sep 03 '24 13:09 danlupascu

Currently WIP in #984, looks close to being done so likely to be fixed in next release👍

matthewlipski avatar Sep 04 '24 15:09 matthewlipski