ObjectFiller.NET icon indicating copy to clipboard operation
ObjectFiller.NET copied to clipboard

Implement phone number generator

Open weitzhandler opened this issue 5 years ago • 2 comments

Hi,

Would be very useful to have a phone number generator. Alternatively allow more customization to the PatternGenerator, so that we can say that we only want a number from 1-9, no zeros, etc.

I posted PR #123 a while ago and no response, so I'm gonna wait to see if this repo is active. I can implement the PhoneGenerator or improve the current PatternGenertor given direction.

Thank you!

weitzhandler avatar May 18 '20 01:05 weitzhandler

Hey! Thank you for your participation. Both ideas are nice. I know I'm a bit lazy. I got father and it takes me a lot more effort like i could imagine :). Anyhow, your participation is welcome

Tynamix avatar May 18 '20 19:05 Tynamix

Thank you so much for your kind responses and congrats on the baby! Sorry that I sounded harsh, I was kinda checking if this repo is active. I tried to reach you guys out on the Gitter room.

Anyway, before doing any implementations, I think we could just change the existing PatternGenerator, add another char-class (let's say n), that means only number from 1 to 9.

Really what we would want is have a base regex pattern generator (like this one for example), then have all our generator based on it where we only have to specify a regex expression in the constructor, then sky is the limit for easy customization.

Please let me know what direction we could be headed.

Thanks

weitzhandler avatar May 18 '20 23:05 weitzhandler