QuickWeather icon indicating copy to clipboard operation
QuickWeather copied to clipboard

True black theme

Open Donkey-Doug opened this issue 4 years ago • 5 comments

Please add a true black theme.

Donkey-Doug avatar Jul 25 '21 00:07 Donkey-Doug

A true black theme is not currently planned, but if there is sufficient excitement I may implement it.

TylerWilliamson avatar Jul 25 '21 06:07 TylerWilliamson

It should be easy. Just replacing all grey with black for both the background and the "cards".

Donkey-Doug avatar Jul 25 '21 09:07 Donkey-Doug

If you implement the "true black" theme and submit a merge request, I will review the request and may approve it.

TylerWilliamson avatar Jul 25 '21 17:07 TylerWilliamson

If you implement the "true black" theme and submit a merge request, I will review the request and may approve it.

Hi Tyler. Is there any plans now for pure black theme. As most of phones nowadays are oled/amoled screens and pure black looks nice on those.

geesquer4u avatar May 15 '24 08:05 geesquer4u

If I'm not mistaken, the change needs to happen over in the TylerUtils library. Specifically in res/values-night/colors.xml:

<color name="card_background">#FF232323</color>

Somehow, and I haven't figured out how, that xml file must be getting loaded. But it should be as easy as adding a res/values-amoled/colors.xml file with the appropriate contents and then conditionally loading it.

To test it, I could just modify the value in `res/values-night/colors.xml'. Except I don't know how to test it.

I have built QuickWeather and loaded it on the emulator. I can make changes to QuickWeather and see those changes in the app.

I've cloned the TylerUtils library and built it, but I have no idea how to get the main QuickWeather build to include it. If anyone knows, I would appreciate some help. I don't work with android apps so this is all new to me.

InTheWorks-ca avatar Jan 26 '25 08:01 InTheWorks-ca