Fix/update pmylund go cache

[titpetric]

trafficstars

Testing change: This PR slightly improves the leaky goroutines behaviour around StartTest/Test.Close. Each test function that invokes startTest may leak several goroutines, one for each of the caches. If not clearing the caches and invoking the garbage collector, leaks accumulate.

Tested with

Test before: 16 -> 24 -> 31 goroutines Test after: 16 -> 18 -> 19

• update import paths for pmylund/go-cache, renamed to patrickmn/go-cache on github (same repo),
• add test case to verify goroutine leaks for StartTest() / .Close(),
• add explicit clear caches to nil and GC invocation in Test.Close(),
• add a Close() and mutex to internal/cache (fix race in tests)

The dependency is not bumped, last release is october 2017 and we are already on latest.

[Tyk-ITS]

API tests result: success :white_check_mark: Branch used: refs/pull/5379/merge Commit:
Triggered by: pull_request (@titpetric) Execution page

[Tyk-ITS]

API tests result: failure :no_entry_sign: Branch used: refs/pull/5379/merge Commit: ba67ef748b0fad7e2889bdcfc3b60ff9a07f1cb0 Triggered by: pull_request (@titpetric) Execution page

[buger]

@CodiumAI-Agent review

[CodiumAI-Agent]

PR Analysis

• 🎯 Main theme: The PR is aimed at improving the goroutine leak behaviour in the StartTest/Test.Close methods. It also updates the import paths for the go-cache library and adds a test case to verify goroutine leaks.
• 📌 Type of PR: Bug fix
• 🧪 Relevant tests added: Yes
• ✨ Focused PR: Yes, the PR is focused as it has a clear title and description that aligns with the changes made in the code. All the changes are related to the issue of goroutine leaks and the update of the go-cache library.
• 🔒 Security concerns: No, the PR does not introduce any obvious security concerns. The changes are primarily related to memory management and do not involve any sensitive data handling or operations that could lead to common security issues like SQL injection, XSS, or CSRF.

PR Feedback

• 💡 General PR suggestions: The PR is well-structured and the changes are well-documented. The addition of a test case to verify goroutine leaks is a good practice. However, it would be beneficial to include more context or comments in the code to explain why certain changes were made, such as the addition of the Close() method and mutex to the internal/cache.

How to use

Tag me in a comment '@CodiumAI-Agent' and add one of the following commands: /review [-i]: Request a review of your Pull Request. For an incremental review, which only considers changes since the last review, include the '-i' option. /describe: Modify the PR title and description based on the contents of the PR. /improve: Suggest improvements to the code in the PR. /ask <QUESTION>: Pose a question about the PR.

To edit any configuration parameter from 'configuration.toml', add --config_path=new_value For example: /review --pr_reviewer.extra_instructions="focus on the file: ..."

[sonarqubecloud[bot]]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

84.4% Coverage
0.0% Duplication

[buger]

@CodiumAI-Agent improve

[Tyk-ITS]

API tests result: success :white_check_mark: Branch used: refs/pull/5379/merge Commit: 9dcbede2acb2967cb25ee3ec32c2fe1a57f8332e Triggered by: pull_request (@buger) Execution page