tyk icon indicating copy to clipboard operation
tyk copied to clipboard

add CertManager function for listing certificates of any kind

Open mitjaziv opened this issue 2 years ago • 9 comments

Description

Change adds ListAny function to CertManager, which enables listing of certificates of
any kind. This change would enable, decoupling of Tyk Identity Broker from Tyk Gateway.

Related Issue

https://github.com/TykTechnologies/tyk-identity-broker/pull/320

Motivation and Context

This change will enable to decoupling of Tyk Gateway from Tyk Identity Broker, by using internal Tyk Identity Broker CertManager interface.

How This Has Been Tested

Screenshots (if appropriate)

Types of changes

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] Refactoring or add test (improvements in base code or adds test coverage to functionality)

Checklist

  • [ ] I ensured that the documentation is up to date
  • [ ] I explained why this PR updates go.mod in detail with reasoning why it's required
  • [ ] I would like a code coverage CI quality gate exception and have explained why

mitjaziv avatar Jul 19 '23 11:07 mitjaziv

API tests result: success :white_check_mark: Branch used: refs/pull/5334/merge Commit:
Triggered by: pull_request (@mitjaziv) Execution page

Tyk-ITS avatar Jul 19 '23 11:07 Tyk-ITS

API tests result: success :white_check_mark: Branch used: refs/pull/5334/merge Commit: 87eec13f4af0ba883b1ed3620b370510121a7383 Triggered by: pull_request (@mitjaziv) Execution page

Tyk-ITS avatar Jul 19 '23 11:07 Tyk-ITS

API tests result: success :white_check_mark: Branch used: refs/pull/5334/merge Commit: 8b66da1c8dd84af6dfb99f2cac8b49364d46bde9 Triggered by: pull_request (@tbuchaillot) Execution page

Tyk-ITS avatar Jul 19 '23 13:07 Tyk-ITS

@CodiumAI-Agent review

buger avatar Aug 02 '23 07:08 buger

PR Analysis

  • 🎯 Main theme: Adding a new function to list certificates of any kind
  • 📌 Type of PR: Enhancement
  • 🧪 Relevant tests added: Yes
  • Focused PR: Yes, the PR is focused as it adds a new function to the CertManager and includes relevant tests for the same. The title and description clearly explain the purpose of the PR.
  • 🔒 Security concerns: No, the PR does not introduce any obvious security concerns. It is focused on listing certificates, and does not appear to introduce any vulnerabilities such as SQL injection, XSS, CSRF, etc.

PR Feedback

  • 💡 General PR suggestions: The PR is well-structured and includes relevant tests for the new function. However, it would be beneficial to include comments in the test cases explaining what each test is doing. Additionally, the PR could benefit from a more detailed description of how the new function contributes to the decoupling of Tyk Gateway from Tyk Identity Broker.

How to use

Tag me in a comment '@CodiumAI-Agent' and add one of the following commands: /review [-i]: Request a review of your Pull Request. For an incremental review, which only considers changes since the last review, include the '-i' option. /describe: Modify the PR title and description based on the contents of the PR. /improve: Suggest improvements to the code in the PR. /ask <QUESTION>: Pose a question about the PR.

To edit any configuration parameter from 'configuration.toml', add --config_path=new_value For example: /review --pr_reviewer.extra_instructions="focus on the file: ..."

CodiumAI-Agent avatar Aug 02 '23 07:08 CodiumAI-Agent

API tests result: success :white_check_mark: Branch used: refs/pull/5334/merge Commit: a8908de43485b38d1c3ec510bff9a04da1cf35c8 Triggered by: pull_request (@buger) Execution page

Tyk-ITS avatar Aug 02 '23 07:08 Tyk-ITS

API Changes

no api changes detected

github-actions[bot] avatar Aug 24 '23 14:08 github-actions[bot]

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell B 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

sonarqubecloud[bot] avatar Aug 24 '23 14:08 sonarqubecloud[bot]

API tests result: success :white_check_mark: Branch used: refs/pull/5334/merge Commit: 9aad2f4430fac26b70cc08f909759bf2838045aa Triggered by: pull_request (@titpetric) Execution page

Tyk-ITS avatar Aug 24 '23 14:08 Tyk-ITS