tyk-operator icon indicating copy to clipboard operation
tyk-operator copied to clipboard

Refactor `integration` package structure

Open buraksekili opened this issue 3 years ago • 1 comments
trafficstars

Description

e2e tests are stored in the ./integration package; however, its current structure is a bit messy for us to continue adding new test cases. Considering the new test cases that will be introduced with GraphQL Federation, the folder will get complicated.

This PR updates folder structure of the integration package. ApiDefinition tests are separated into feature properties as defined in the ApiDefinition docs. For example, features regarding ApiDefinitions' Endpoint MW are moved into apidefinition_endpoint_mw_test.go.

At a later time, we may even need to update test case structure in order to establish consistency among tests.

Related Issue

Motivation and Context

Test Coverage For This Change

Screenshots (if appropriate)

Types of changes

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • [ ] Make sure you are requesting to pull a topic/feature/bugfix branch (right side). If PRing from your fork, don't come from your master!
  • [ ] Make sure you are making a pull request against our master branch (left side). Also, it would be best if you started your change off our latest master.
  • [ ] Make sure you are updating CHANGELOG.md based on your changes.
  • [ ] My change requires a change to the documentation.
    • [ ] If you've changed APIs, describe what needs to be updated in the documentation.
  • [ ] I have updated the documentation accordingly.
  • [ ] I have added tests to cover my changes.
  • [ ] All new and existing tests passed.
  • [ ] Check your code additions will not fail linting checks:
    • [ ] gofmt -s -w .
    • [ ] go vet ./...
    • [ ] golangci-lint run

buraksekili avatar Jun 09 '22 22:06 buraksekili