DynamicPPL.jl
DynamicPPL.jl copied to clipboard
TuringLang
Remove `BangBang.possible`
In light of https://github.com/JuliaFolds2/BangBang.jl/commit/e679bae34a531ad8adc7dc1d896028958be2e532, we can removed the code as they are implemented in BangBang.
The changes has not been released, so should verify afterward. And this PR should not be merged right now.
related: https://github.com/TuringLang/DynamicPPL.jl/issues/530
I don't understand why Document-CI is failing, FLoop is not in BangBang's deps.
Maybe Floop is in the deps on another package? I think Julia's package manager has a mechanism to figure which package requires a specific deps.
I don't understand why Document-CI is failing, FLoop is not in BangBang's deps.
MLUtils is a docs dependency and depends on FLoops - however FLoops does not support BangBang >= 0.4 currently.
MLUtils is used in a single example: https://github.com/TuringLang/DynamicPPL.jl/blob/abcf5843856235cf8ee391b67bcde2750cb2aa56/docs/src/tutorials/prob-interface.md?plain=1#L112-L141 Since it's a quite heavy dependency, I wonder if we could avoid it.
Okay, the situation is a bit troublesome.
BangBang v0.4 moved to Accesssors, so all the Setfield related code are erroring out.
Now, either we led some effort in backporting the possible fix to v0.3, or ourselves move to Accessors too.
The interface diff between Setfield and Accessors should be minimal for our purpose, though.
Now, either we led some effort in backporting the possible fix to v0.3, or ourselves move to Accessors too.
Let's move to Accessors too. @sunxd3, can you create a PR for that next week?
Pull Request Test Coverage Report for Build 8745141284
Details
- 0 of 0 changed or added relevant lines in 0 files are covered.
- No unchanged relevant lines lost coverage.
- Overall coverage decreased (-0.03%) to 81.821%
| Totals | |
|---|---|
| Change from base Build 8745047931: | -0.03% |
| Covered Lines: | 2615 |
| Relevant Lines: | 3196 |
