Tobias Bieniek comments

Results 625 comments of


                                            Tobias Bieniek

Splitting Ember into packages

> isn't the issue resolved by including eslint as a direct dependency of the app? then something like `yarn run eslint` would potentially run a different ESLint version than the...

Use `Object.assign` instead of `assign` from `@ember/polyfills`

I'm no longer on the ember-cli team, I'm not maintaining this addon and I'm not even using it anymore. Feel free to ping the ember-cli team though 🤷‍♂️

Route is not retained after refresh

our `router.js` file: ```js import AddonDocsRouter, { docsRoute } from 'ember-cli-addon-docs/router' import config from './config/environment' const Router = AddonDocsRouter.extend({ location: config.locationType, rootURL: config.rootURL }) Router.map(function() { docsRoute(this, function() { this.route('installation')...

Update embroider monorepo to v1 (major)

@scalvert @rwjblue @ef4 any ideas how we can make this PR green?

Update embroider monorepo to v1 (major)

hmm okay, so the easiest way forward would be to not use a dummy app, but a monorepo with an app instead?

Update embroider monorepo to v1 (major)

hmm, CI still red, though potentially for different reasons

Issue with assert.dom(this.element) types with latest Ember and QUnit

Yes, we intentionally do not accept document because it is missing some APIs

This whitespace replace regex is not replacing   encoded whitespaces.

> assert.dom('p').hasText('a b') would fail that is intentional because multiple `nbsp` are not collapsed into a single whitespace.

This whitespace replace regex is not replacing   encoded whitespaces.

`hasText()` supports regex expectations. maybe that helps?

Add assertion is-not-overflowing

looks generally alright, although I'm uncertain how useful this assertion will ultimately be. since it potentially depends on the browser window size and other dynamic factors it seems a bit...