feat: change add tags to edit tags

[im-adithya]

Fixes https://github.com/TryGhost/Ghost/issues/21414

Description

As per @ErisDS' suggestion in https://github.com/TryGhost/Ghost/pull/21787, I tried to make some changes in the UI. I thought editing/updating tags is better than adding tags so I modified the add tags modal to do that instead.

Recording

https://github.com/user-attachments/assets/5686222f-7ef1-4603-8797-2457be5e6241

Checklist

• [x] There's a clear use-case for this code change, explained below
• [x] Commit message has a short title & references relevant issues
• [x] The build will pass (run yarn test:all and yarn lint)

[coderabbitai[bot]]

[!NOTE] Currently processing new changes in this PR. This may take a few minutes, please wait...

📥 Commits

Reviewing files that changed from the base of the PR and between f2f4fda9092e7233da82eaaf9f2948ea362a6925 and 7ce7a69cc0d401769ffba42d190b76fd52c82469.

📒 Files selected for processing (6)

• ghost/admin/app/components/posts-list/context-menu.hbs (1 hunks)
• ghost/admin/app/components/posts-list/context-menu.js (6 hunks)
• ghost/admin/app/components/posts-list/modals/edit-tag.hbs (2 hunks)
• ghost/admin/app/components/posts-list/modals/edit-tag.js (4 hunks)
• ghost/admin/tests/acceptance/content-test.js (5 hunks)
• ghost/posts-service/lib/PostsService.js (2 hunks)

 _________________________________________________
< PhD, MSc, BSc, and a black belt in code review. >
 -------------------------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       / 　 づ

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[im-adithya]

@kevinansfield I need input on how to proceed with multiple post selection while adding/removing tags. Currently I show the union of all the posts selected, and the updates are currently processed as follows:

• add tags to all posts if created newly
• remove tags from all posts where it exists if a tag is removed

[kevinansfield]

I'm a bit confused as to what this PR is attempting to do. The modal is only useful for bulk adding tags to the selected posts so "edit" is a bit misleading as there's no realistic way to change the existing tags on the selected posts. E.g. if you select a series of posts that all have existing, different, tags then you wouldn't expect to see all tags in the modal and it would be very counterintuitive if that new tags list was then applied to all of the selected posts.

I would suggest starting off with a comment on the relevant issue explaining your proposed change and asking for design input before pushing ahead with a PR 🙂

[im-adithya]

Sorry for that 😬

I originally thought there was no option to select multiple posts and call "Add a tag" for all at once. So I thought if it's just for a single post, we better call it Edit instead of Adding similar to how we do it in the sidebar* to avoid confusion.

*referring to this:

[kevinansfield]

Closing this PR because the approach isn't workable (see https://github.com/TryGhost/Ghost/pull/22534#issuecomment-2732146296) and doesn't resolve the underlying data consistency problem.