TrinityCore
TrinityCore copied to clipboard
TrinityCore
Nefarian Stage 3
Description: The adds on phase 3 do not ever come back to life and attack the players.
Current behaviour: On phase 3, corpses from the mobs we killed during phase 1, do not come back to life as skeletal constructs.
Expected behaviour: The corpses of the mobs we killed during phase 1 should revive as full hp skeletal constructs on phase 3.
Steps to reproduce the problem:
- Head to Nefarian (.tele bwl)
- Start the encounter
- Kill the adds until Nefarian takes his dragon form
- Get him below 20% hp
- Nefarian does the SAY_RAISE_SKELETONS as scripted. Nothing else happens.
Branch(es): 3.3.5 (TDB 335.64)
TC rev. hash/commit: 59682bbd9b33
Operating system: #W10
Notes I've managed to fix most of this phase but i dont know how to make a Pull Request yet, i will get to it in a few hours.
Feel free to ask for help if you are having trouble creating the PR. You also have the option to ask in IRC: #Trinity @ irc.rizon.net
This problem stills exists as of 9d959123e68020a83c780f53a967b3589cb70786.
And when Nefarian has 5% HP, he should say
ENOUGH! Now you vermin shall feel the force of my birthright: The Fury of the Earth itself!
, according to Wowpedia, which he does not.
(link to the script file) https://github.com/TrinityCore/TrinityCore/blob/3.3.5/src/server/scripts/EasternKingdoms/BlackrockMountain/BlackwingLair/boss_nefarian.cpp
The OP issue seems to deal mostly with the following part of the script: https://github.com/TrinityCore/TrinityCore/blob/41188eb535e445b73909659980257da2939e4be4/src/server/scripts/EasternKingdoms/BlackrockMountain/BlackwingLair/boss_nefarian.cpp#L570-L587
Is there something wrong with if ((*itr) && !(*itr)->IsAlive()) that makes the script skip the Respawn() section completely?
