angular-application-insights icon indicating copy to clipboard operation
angular-application-insights copied to clipboard

publish(9.0.3): fix peerDep angular router for v14

Open TPullen21 opened this issue 3 years ago • 9 comments

Resolves #119

TPullen21 avatar Sep 08 '22 16:09 TPullen21

@MarkPieszak Can this be reviewed and merged?

superjulius avatar Sep 16 '22 08:09 superjulius

bump. Would like this merged as well. any issues?

wolfpackt99 avatar Oct 11 '22 16:10 wolfpackt99

When will this be merged >.<?

iLouminate avatar Oct 18 '22 15:10 iLouminate

@MarkPieszak how can I help get this merged?

naticaceres avatar Nov 10 '22 03:11 naticaceres

Is it possible to merge this branch soon?

notsaltydev avatar Nov 30 '22 07:11 notsaltydev

why do people even use peer dependency range? I mean why not simply use a minimal greater than version instead of a fixed version? I tried upgrading to Angular 15 and it throws an error and I can't work unless I use a --force install. In my own Angular libs, I simply never use any peer deps but if we really want to use peer deps, then why not use something simpler like this:

"@angular/router": ">=10.0.0"

at least this would work with current and future versions instead of being bugged down every time a new Angular version comes out, which is quite often. This would require a lot less maintenance too

ghiscoding avatar Jan 11 '23 17:01 ghiscoding

@TPullen21 can you complete this PR?

wolfpackt99 avatar Mar 20 '23 13:03 wolfpackt99

@wolfpackt99 I don't have the rights to complete, it's up to @MarkPieszak.

TPullen21 avatar Mar 20 '23 14:03 TPullen21