react-carousel
react-carousel copied to clipboard
ScrollingCarousel does not respond to click sometimes
Describe the bug
Hello,
I spot this bug when using ScrollingCarousel component. Sometimes, when click on an item, it doesn't respond to the click event. I think it's caused by the mouseMove and mouseDown event both fired. Could you please take a look at this and fix if that's possible? Thank you so much.
Reproduction
https://user-images.githubusercontent.com/7519225/164739212-6e702305-85f0-45f0-af18-41945e0d5e3a.mov
System Info
System:
OS: macOS 11.5.1
CPU: (8) arm64 Apple M1
Memory: 100.41 MB / 8.00 GB
Shell: 5.8 - /bin/zsh
Binaries:
Node: 16.10.0 - /opt/homebrew/bin/node
Yarn: 1.22.17 - /opt/homebrew/bin/yarn
npm: 7.24.0 - /opt/homebrew/bin/npm
Browsers:
Chrome: 100.0.4896.127
Firefox: 98.0
Safari: 14.1.2
npmPackages:
@trendyol-js/react-carousel: ^2.0.1 => 2.0.1
Used Package Manager
npm
Logs
No response
Validations
- [X] Follow our Code of Conduct
- [X] Read the Contributing Guidelines.
- [X] The provided reproduction is a minimal reproducible example of the bug.
@jeremylin8 did you try the triggerClickOn prop? if you set triggerClickOn={10} it will trigger click events even if you move your mouse 10px. (you should update the version v3.0.0-beta.4)
@hasangenc0 I think triggerClickOn prop is only in Carousel component. Can you guys please add it to the ScrollingCarousel component as well?
I think we can. let's see if we have free time to do it this week.
Hey @hasangenc0, any updates on this feature? Thanks a lot!
+1. Running into the same issue with ScrollingCarousel