Add argmax function to Numpy Frontend

[garlicdevs]

trafficstars

#3470

[garlicdevs]

Hi @bicycleman15 , look like some errors do not relate to my code

[bicycleman15]

Hey @garlicdevs it's a good start. However, you still need to add tests for your frontend function. I would suggest you go through the contributor guide if you need to reference on how to implement tests for frontend functions. Feel free to message if you have any questions. 🙂

[garlicdevs]

@bicycleman15 sure thanks mate :)

[garlicdevs]

Hi @bicycleman15 , I just added the test, can you review it please? Thanks

[garlicdevs]

Hi @bicycleman15 , I think the source code in ivy master is quite inconsistent, there should be no docstring in front-end APIs, but I saw some functions having those like argmin and nonzero.

Test strategies are also inconsistent. I just followed Daniel @djl11 test sample code to write the test function. For example, the order of variables in the "given" decorators should be consistent. Which params should be defined hypothesis strategies, etc.

[bicycleman15]

Hey @garlicdevs , you are correct. Frontend function should not have docstrings. It is also true that argument order is inconsistent. I believe since many people are contributing, sometimes these things slip by I guess.

[ivy-seed]

This PR has been labelled as stale because it has been inactive for more than 7 days. If you would like to continue working on this PR, then please add another comment or this PR will be closed in 7 days.

[ivy-seed]

This PR has been closed because it has been marked as stale for more than 7 days with no activity.