nativelink
nativelink copied to clipboard
Improve config JSON readability and composability
Description
Currently, I've improved the readability and composability of the JSON file by applying the changes mentioned in the issue.
We now have "name" and "config" field for an individual store and scheduler JSON for setting its name and its configurations. And "stores" and "schedulers" field now accepts array instead of map.
Fixes #834
Type of change
- [x] New feature (non-breaking change which adds functionality)
- [x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [x] This change requires a documentation update
Checklist
- [x] Updated documentation if needed
- [x] Tests added/amended
- [x]
bazel test //...passes locally - [x] PR is contained in a single commit, using
git amendsee some docs
I hope you to review this. @MarcusSorealheis , @allada , @aaronmondal , @adam-singer Thanks.
Well, @allada wanted that to be config instead of options.
See this discussion below.
#834
What would be the correct wording for that? I want you to clear that. Thanks. cc: @allada , @MarcusSorealheis
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.