nativelink icon indicating copy to clipboard operation
nativelink copied to clipboard

Improve config JSON readability and composability

Open blizzardc0der opened this issue 1 year ago • 3 comments

Description

Currently, I've improved the readability and composability of the JSON file by applying the changes mentioned in the issue.

We now have "name" and "config" field for an individual store and scheduler JSON for setting its name and its configurations. And "stores" and "schedulers" field now accepts array instead of map.

Fixes #834

Type of change

  • [x] New feature (non-breaking change which adds functionality)
  • [x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [x] This change requires a documentation update

Checklist

  • [x] Updated documentation if needed
  • [x] Tests added/amended
  • [x] bazel test //... passes locally
  • [x] PR is contained in a single commit, using git amend see some docs

This change is Reviewable

blizzardc0der avatar Apr 26 '24 19:04 blizzardc0der

I hope you to review this. @MarcusSorealheis , @allada , @aaronmondal , @adam-singer Thanks.

blizzardc0der avatar Apr 27 '24 15:04 blizzardc0der

Well, @allada wanted that to be config instead of options. See this discussion below. #834

What would be the correct wording for that? I want you to clear that. Thanks. cc: @allada , @MarcusSorealheis

blizzardc0der avatar Apr 30 '24 16:04 blizzardc0der

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar May 15 '24 21:05 CLAassistant