tracardi
tracardi copied to clipboard
Tracardi
We need to replace request with asyncRemote
We need to replace request with asyncRemote. Contrary to remote, asyncRemote can be used as awaitable.
Task
Find all occurrences of request calls and replace them with asyncRemote.
Use where possible the async way of calling the method. Example
try {
const response = await asyncRemote({
url: '/tracardi',
method: "POST",
data: data
})
// ...
} catch (e) {
// ....
}
It is not possible to make call awaitable in useEffects. Then handle it with promise.
asyncRemote({
url: '/tracardi',
method: "POST",
data: data
}).then((response) => {
// ...
}).catch((e)=> {
// ...
});
Test it thoroughly. Test every change separately.
Do not forget to set loading where it was used.
For example:
This code:
useEffect(() => {
request({url: "/info/version"}, setLoading, () => {}, setReady);
}, [])
Should be replaced like this. No await because it is in useEffects.
useEffect(() => {
setLoading(true);
asyncRemote(
{url: "/info/version"}
).then((response) => {
if (response?.status == 200) {
setReady(response.data)
}
}).catch((e) => {
}).finally(()=>{setLoading(false);});
}, [])
mind the setLoading.
If it was not in useEffects always use it like this
try {
setLoading(true);
const response = asyncRemote(
{url: "/info/version"}
)
} catch(e) {
// ...
} finally {
setLoading(false);
}
Hello @atompie , Can you assign this issue to me?
@M-RAY47 Sure. Please make a PR after first change so we can CR it and see if you are going in the right direction. Otherwise if something is not right then you may loose a lot of time.
Hello @atompie , Can you assign this issue to me?
@M-RAY47 Sure. Please make a PR after first change so we can CR it and see if you are going in the right direction. Otherwise if something is not right then you may loose a lot of time.
Ok, I am on it.
Sorry to ask what PR and CR mean?
Can you give some hint because I couldn't locate javaScript files, most of them are python files
@M-RAY47 If you are working on this task please update the code frequently as the is continuous change and some of the parts of this task may be already done.
@atompie hello, sir I think you can close this issue from this project, because it should in the other project "Tracardi-gui"
