Anton Hvornum

Results 461 comments of Anton Hvornum

I agree that simply importing the library shouldn't trigger things. It's fine for what we use it for so I've let it slide for a few years now. We should...

In the old days, dinosaur times, the tool could also be used as Python lib to do package search and stuff. If you wanted to avoid using `subprocess` yourself. But...

Correct. GitHub used to redirect users here automatically, after the project was transferred from my account to the distro's account. But once I forked it myself that redirect got broken....

Thanks for fixing this @svartkanin! Issue link should now point correctly!

On the phone so hard to search, but didn't we already have a `except Exception` to catch all errors related to mirror tests? And if my memory servers, we also...

Before we merge this, I have to create a `python-pylint-pydantic` package as we need to be able to source this during [PKGBUILD](https://github.com/archlinux/archinstall/blob/master/PKGBUILD): ```diff makedepends=( 'python-setuptools' 'python-sphinx' 'python-build' 'python-installer' 'python-wheel' +...

Because we *should* run [check()](https://wiki.archlinux.org/title/Python_package_guidelines#Check) in [PKGBUILD](https://wiki.archlinux.org/title/PKGBUILD#checkdepends). I haven't been a model packaging citizen, but now that we're doing good stuff this should ideally be there :)

> Hmm I'm still somewhat worried that mixing the build with linting may cause issues down the line. If these checks run on PRs and only PRs that validate successfully...

It's true, we could skip the `check()` in PKGBUILD's for now. But knowing myself it will probably be forgotten until someone pokes me or when it bites me in the...

I've successfully built the dependencies now. I just need to sign and publish the packages :) Edit: Been on vacation for a week, but picking this up again.