ghidra-findcrypt
ghidra-findcrypt copied to clipboard
10.2 Introducing Breaking Change
Just wanted to give you a heads up that there is a change coming in Ghidra 10.2 that will break this extension. It is an easy fix and will only require a 2 line change. The DataTypeConflictException class has been removed.
Thanks for the heads up @astrelsky!
Time to fix this!
Hi @TorgoTorgo - any update on when this fix will be implemented? Thank you.
Oh, it really was a two-line fix :-).
Instead of just agreeing on what the fix is, post it for future googlers.
diff --git a/FindCrypt/src/main/java/findcrypt/FindCryptAnalyzer.java b/FindCrypt/src/main/java/findcrypt/FindCryptAnalyzer.java
index b5b4075..41bec1e 100644
--- a/FindCrypt/src/main/java/findcrypt/FindCryptAnalyzer.java
+++ b/FindCrypt/src/main/java/findcrypt/FindCryptAnalyzer.java
@@ -28,7 +28,6 @@ import ghidra.program.model.address.Address;
import ghidra.program.model.address.AddressSetView;
import ghidra.program.model.data.ArrayDataType;
import ghidra.program.model.data.ByteDataType;
-import ghidra.program.model.data.DataTypeConflictException;
import ghidra.program.model.listing.Program;
import ghidra.program.model.symbol.SourceType;
import ghidra.program.model.util.CodeUnitInsertionException;
@@ -115,7 +114,7 @@ public class FindCryptAnalyzer extends AbstractAnalyzer {
try {
program.getListing().createData(found_addr, dt);
- } catch (CodeUnitInsertionException | DataTypeConflictException e) {
+ } catch (CodeUnitInsertionException e) {
// We failed to attach the datatype, this is probably due to existing data
// If that's the case, we probably don't want to overwrite it...
Msg.warn(this, "Could not apply datatype for crypt constant", e);
Solved by PR https://github.com/TorgoTorgo/ghidra-findcrypt/pull/24
I would like if a maintainer would merge this in.