ghidra-findcrypt icon indicating copy to clipboard operation
ghidra-findcrypt copied to clipboard

10.2 Introducing Breaking Change

Open astrelsky opened this issue 3 years ago • 1 comments

Just wanted to give you a heads up that there is a change coming in Ghidra 10.2 that will break this extension. It is an easy fix and will only require a 2 line change. The DataTypeConflictException class has been removed.

astrelsky avatar May 23 '22 11:05 astrelsky

Thanks for the heads up @astrelsky!

TorgoTorgo avatar Jun 06 '22 04:06 TorgoTorgo

Time to fix this!

TorgoTorgo avatar Nov 08 '22 10:11 TorgoTorgo

Hi @TorgoTorgo - any update on when this fix will be implemented? Thank you.

as0ni avatar Jan 13 '23 16:01 as0ni

Oh, it really was a two-line fix :-).

as0ni avatar Jan 13 '23 16:01 as0ni

Instead of just agreeing on what the fix is, post it for future googlers.

diff --git a/FindCrypt/src/main/java/findcrypt/FindCryptAnalyzer.java b/FindCrypt/src/main/java/findcrypt/FindCryptAnalyzer.java
index b5b4075..41bec1e 100644
--- a/FindCrypt/src/main/java/findcrypt/FindCryptAnalyzer.java
+++ b/FindCrypt/src/main/java/findcrypt/FindCryptAnalyzer.java
@@ -28,7 +28,6 @@ import ghidra.program.model.address.Address;
 import ghidra.program.model.address.AddressSetView;
 import ghidra.program.model.data.ArrayDataType;
 import ghidra.program.model.data.ByteDataType;
-import ghidra.program.model.data.DataTypeConflictException;
 import ghidra.program.model.listing.Program;
 import ghidra.program.model.symbol.SourceType;
 import ghidra.program.model.util.CodeUnitInsertionException;
@@ -115,7 +114,7 @@ public class FindCryptAnalyzer extends AbstractAnalyzer {
 						
 						try {
 							program.getListing().createData(found_addr, dt);
-						} catch (CodeUnitInsertionException | DataTypeConflictException e) {
+						} catch (CodeUnitInsertionException e) {
 							// We failed to attach the datatype, this is probably due to existing data
 							// If that's the case, we probably don't want to overwrite it...
 							Msg.warn(this, "Could not apply datatype for crypt constant", e);

hanetzer avatar Jan 26 '23 08:01 hanetzer

Solved by PR https://github.com/TorgoTorgo/ghidra-findcrypt/pull/24

antoniovazquezblanco avatar Jan 26 '23 08:01 antoniovazquezblanco

I would like if a maintainer would merge this in.

EvanEzell avatar Mar 01 '23 14:03 EvanEzell