Ensemble-Pytorch icon indicating copy to clipboard operation
Ensemble-Pytorch copied to clipboard

Fix 'ReduceLROnPlateau' has no attribute 'get_last_lr'

Open irg1008 opened this issue 3 years ago • 1 comments

This scheduler doesn't have this attributte because it doesn't inherit from _LRScheduler, and simply implementes the generic 'object' class.

Instead of getting the leanring rate with get_last_lr, we could fetch it with optimizer.param_groups[0]['lr'] for this very specific case.

irg1008 avatar Apr 03 '22 10:04 irg1008

Hi @irg1008, thanks for your kind reminder, will appreciate a PR very much ;-)

xuyxu avatar Apr 04 '22 03:04 xuyxu

Hi @xuyxu, if you are still looking for a PR, I would be happy to work on it

SarthakJariwala avatar Sep 23 '22 05:09 SarthakJariwala

Great! Feel free to work on it, and let me know if you need any help ;-) @SarthakJariwala

xuyxu avatar Sep 23 '22 12:09 xuyxu

Hi @xuyxu - see PR #128 :-)

SarthakJariwala avatar Sep 24 '22 01:09 SarthakJariwala