ToolJet icon indicating copy to clipboard operation
ToolJet copied to clipboard

Published 20 hours ago • verified publisher icon ToolJet

[docs]: Fix documentation for Code Editor Component

Open JP-sDEV opened this issue 1 year ago • 18 comments

Fixes: #11018

Formatting Updates:

  • replaced "Fx" with "fx"
  • removed padding-bottom from all ##/h2 elements
  • added a divider before the "Styles" section

Content Updates:

  • replaced "widget" with "component", without updating the URLs
  • updated and reworded the "value" row in the "Exposed Variables" table

JP-sDEV avatar Oct 18 '24 15:10 JP-sDEV

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Oct 18 '24 15:10 CLAassistant

Code Review Agent Run Status

  • Limitations and other issues: The AI Code Review Agent was unable to review this change because Bito workspace ToolJet is downgraded to the plan that doesn’t include Code Review Agent feature.

    Please coordinate with your workspace admin to request an upgrade to the 10X Developer Plan.

TooljetBot avatar Oct 18 '24 15:10 TooljetBot

Hey @JP-sDEV, you were supposed to make changes in the two versions as follows:

  • Next - ToolJet/docs/docs/widgets/code-editor.md
  • Version 2.50.0 (LTS) - ToolJet/docs/versioned_docs/version-2.50.0-LTS/widgets/code-editor.md

But I think by mistake you have made changes in 2.5.0 instead of 2.50.0 (LTS) Can you please revert all the changes from 2.5.0 and make the changes in the correct file?

RudraPratik30 avatar Oct 21 '24 09:10 RudraPratik30

Code Review Agent Run Status

  • Limitations and other issues: The AI Code Review Agent was unable to review this change because Bito workspace ToolJet is downgraded to the plan that doesn’t include Code Review Agent feature.

    Please coordinate with your workspace admin to request an upgrade to the 10X Developer Plan.

TooljetBot avatar Oct 21 '24 13:10 TooljetBot

@RudraPratik30 Apologies for the mistake, I have made the corrections and pushed the changes. Thank you! :)

JP-sDEV avatar Oct 21 '24 13:10 JP-sDEV

Code Review Agent Run Status

  • Limitations and other issues: The AI Code Review Agent was unable to review this change because Bito workspace ToolJet is downgraded to the plan that doesn’t include Code Review Agent feature.

    Please coordinate with your workspace admin to request an upgrade to the 10X Developer Plan.

TooljetBot avatar Oct 22 '24 06:10 TooljetBot

Code Review Agent Run Status

  • Limitations and other issues: The AI Code Review Agent was unable to review this change because Bito workspace ToolJet is downgraded to the plan that doesn’t include Code Review Agent feature.

    Please coordinate with your workspace admin to request an upgrade to the 10X Developer Plan.

TooljetBot avatar Oct 22 '24 15:10 TooljetBot

Code Review Agent Run Status

  • Limitations and other issues: The AI Code Review Agent was unable to review this change because Bito workspace ToolJet is downgraded to the plan that doesn’t include Code Review Agent feature.

    Please coordinate with your workspace admin to request an upgrade to the 10X Developer Plan.

TooljetBot avatar Oct 22 '24 15:10 TooljetBot

Thank you, suggested fixes have been implemented! :)

JP-sDEV avatar Oct 22 '24 15:10 JP-sDEV

Hey @JP-sDEV,

Are you still working on it? Please let us know if you need any help.

PriteshKiri avatar Oct 25 '24 06:10 PriteshKiri

Hey @JP-sDEV,

Are you still working on it? Please let us know if you need any help.

Yes still working on it. Apologies, was away from computer the past weekend. Should have the updates done today.

JP-sDEV avatar Oct 28 '24 14:10 JP-sDEV

Code Review Agent Run Status

  • Limitations and other issues: The AI Code Review Agent was unable to review this change because Bito workspace ToolJet is downgraded to the plan that doesn’t include Code Review Agent feature.

    Please coordinate with your workspace admin to request an upgrade to the 10X Developer Plan.

TooljetBot avatar Oct 28 '24 15:10 TooljetBot

Pushed the changes with the recommended changes. No issues with running locally via npm start.

JP-sDEV avatar Oct 28 '24 15:10 JP-sDEV

Code Review Agent Run Status

  • Limitations and other issues: The AI Code Review Agent was unable to review this change because Bito workspace ToolJet is downgraded to the plan that doesn’t include Code Review Agent feature.

    Please coordinate with your workspace admin to request an upgrade to the 10X Developer Plan.

TooljetBot avatar Oct 29 '24 11:10 TooljetBot

Deployment: https://tooljet-pr-11027.onrender.com Dashboard: https://dashboard.render.com/static/srv-csgcfuhu0jms738uherg

github-actions[bot] avatar Oct 29 '24 11:10 github-actions[bot]

Code Review Agent Run Status

  • Limitations and other issues: The AI Code Review Agent was unable to review this change because Bito workspace ToolJet is downgraded to the plan that doesn’t include Code Review Agent feature.

    Please coordinate with your workspace admin to request an upgrade to the 10X Developer Plan.

TooljetBot avatar Oct 29 '24 12:10 TooljetBot

Code Review Agent Run Status

  • Limitations and other issues: The AI Code Review Agent was unable to review this change because Bito workspace ToolJet is downgraded to the plan that doesn’t include Code Review Agent feature.

    Please coordinate with your workspace admin to request an upgrade to the 10X Developer Plan.

TooljetBot avatar Oct 29 '24 12:10 TooljetBot

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Oct 29 '24 12:10 sonarqubecloud[bot]