ToolJet icon indicating copy to clipboard operation
ToolJet copied to clipboard

Update client.Dockerfile

Open AranavMahalpure opened this issue 1 year ago • 3 comments

This pull request refactors the Dockerfile to streamline the build process, improve performance, and reduce the final image size for ToolJet's frontend and plugins. It uses a multi-stage build process to separate the build environment (Node.js) from the runtime environment (OpenResty), ensuring that only the essential assets are included in the final image

AranavMahalpure avatar Oct 14 '24 17:10 AranavMahalpure

Code Review Agent Run Status

  • Limitations and other issues: The AI Code Review Agent was unable to review this change because Bito workspace ToolJet is downgraded to the plan that doesn’t include Code Review Agent feature.

    Please coordinate with your workspace admin to request an upgrade to the 10X Developer Plan.

TooljetBot avatar Oct 14 '24 17:10 TooljetBot

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Oct 14 '24 17:10 CLAassistant

Thanks for the suggestion @AranavMahalpure!

Our team will look into it!

Feel free to contribute on the issues with labels community contribution 🙌

PriteshKiri avatar Oct 18 '24 05:10 PriteshKiri

Hi @AranavMahalpure ,

the dockerfile which you have made changes is a old one. Please refer the current one, since we have upgrade the Node version 14 to 18.

adishM98 avatar Oct 18 '24 05:10 adishM98

Hey @AranavMahalpure ,

As @adishM98 mentioned, the PR involves changes to an outdated Dockerfile, so it isn't relevant to the current version.

If you'd like to contribute to ToolJet, please check out issues with the community contribution label. We'd love to see your contributions there!

PriteshKiri avatar Oct 18 '24 08:10 PriteshKiri