Tolriq

Results 240 comments of Tolriq

Unfortunately IMO in the way OS API is supposed to be build, to be able to have temporary token we need a way to know the limits of that token...

Thanks. @kgarner7 a few quick notes: - If you want the keyUrl tied to the extension then the extension page doc must say that that endpoint is part of the...

Lol sorry some merge error then :) Will wait before commenting again :)

Ok so still the question about "an error 44 Invalid apiKey" to differentiate from the 40 invalid login/password. Else change the message / description of 40 to also cover apiKey...

Optional question but could there be a case in your needs for v2 where a key could not be tied to an user and we should define a default value?...

null is not valid, so if would be empty if not a well know value. For the **if** that's the question, I can't think of a reason but maybe some...

Yes requiring is ok. But no we can't make a required field optional later this is breaking change for any client that enforce the schema or is not prepared for...

Also pinging @tonihei since he did the rework on the audiotrack async init/release and the recent changes to volume ramp kinda match the needs here.

@tonihei VolumeShaper by itself is pretty easy to use, the only actual issue is getting access to the proper `AudioTrack` to be sure to apply the correct effect to the...

@tonihei So looking a little more in DefaultAudioSink and all the different cases, I think the need can be quite simply filled by adding an `onAudioTrackConfigured` event to `AudioSink.Listener`. Then...