Tolriq
Tolriq
Bump ? Currently applying the RG via ffmpeg as a secondary solution but this is not efficient at all. A future native solution would be better.
Can try that after holidays but not sure about the flush on configure. Currently this does not happen when the format is the same, that's why we can't just disable...
Ok so @tonihei @Samrobbo I did a quick test. `configure` on the AudioSink is properly called on same format between tracks and is called at the proper time so it...
Actually got my answer: https://github.com/androidx/media/blob/main/libraries/exoplayer/src/main/java/androidx/media3/exoplayer/audio/MediaCodecAudioRenderer.java#L560 And https://github.com/androidx/media/blob/main/libraries/exoplayer/src/main/java/androidx/media3/exoplayer/audio/DecoderAudioRenderer.java#L446 The metadata is not passed down. Adding: ``` .setMetadata(inputFormat.metadata) ``` To `DecoderAudioRenderer` and ``` .setMetadata(format.metadata) ``` To `MediaCodecAudioRenderer` Seems to fix all the...
So I'm late with my luggage but configuring the AP at that moment works perfectly including Gapless. Would be really nice if there was a proper way to ensure that...
Bump. At least to have confirmation that by doing so in my fork I won't have side effects I did not see yet.
Ok perfect thanks. Should I make a PR as it might be helpful globally for others no?
@tonihei done : https://github.com/androidx/media/pull/594 BTW unrelated but there's a tons of nullability issues in 1.2 (Never really checked that part of the code before). Like https://github.com/androidx/media/blob/main/libraries/exoplayer/src/main/java/androidx/media3/exoplayer/audio/MediaCodecAudioRenderer.java#L536 The mediaFormat is explicitly...
Seems ExoPlayer does not extract metadata from WAV (probably normal since there's no official ways), but even if I do have the RG values I can't find a way to...
@tonihei @Samrobbo Bump on this one, I got some other case where I now get the replaygain data outside of the tags and can't figure out a way to pass...