TJ-Bot icon indicating copy to clipboard operation
TJ-Bot copied to clipboard

Published 20 hours ago • verified publisher icon Together-Java

Add @MethodsReturnNonnullByDefault

Open Zabuzard opened this issue 3 years ago • 3 comments
trafficstars

Closes #548. Similar to #541, this adds an annotation @MethodsReturnNonnullByDefault to all packages.

Effectively making @Nonnull completely obsolete in our code base - hence also removing it everywhere.

The annotation is self-written (idea snacked from Minecraft who has this annotation as well - credits go to Quinteger for raising awareness).

The PR will of course generate a lot of (simple) merge conflicts - again. But I think people will like it 👍

Everyone say goodbye to @Nonnull 👋 goodbye

Zabuzard avatar Aug 29 '22 12:08 Zabuzard

"database" subproject also has those annotations. Maybe create a separate subproject that will hold that annotation? This way "application" and "database" won't have to depend on each other.

Quinteger avatar Aug 29 '22 12:08 Quinteger

auto merging this on the weekend if no approves come in sooner 👍

Zabuzard avatar Sep 01 '22 08:09 Zabuzard

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Sep 01 '22 18:09 sonarqubecloud[bot]