TJ-Bot
TJ-Bot copied to clipboard
Together-Java
Forbid posting blacklisted files
Close #484
Added BlacklistedAttachmentListener which delete any blacklisted file attachment. The listener sent a dm to the user and informs the Mods.
Scenario message with blacklisted file extension:
Posting message
User message was deleted
Response from listener
Message to the Mods
Scenario message without blacklisted file extension:
Posting message
Message wont be deleted
No blacklisted file extension found therefore no deletion 😄
Config
The config was slightly changed, the following was added:
"blacklistedFileExtension": "memes"
I would expand the list to all or almost all common widows executables. You can find many lists online, this was the first hit for me: https://www.howtogeek.com/137270/50-file-extensions-that-are-potentially-dangerous-on-windows/
There are a bunch of executables for linux/mac, but viruses for these are basically nonexistent, since it's very hard to do anything without necessary permissions. For example, you can't even run an executable without giving it explicit execute permission. So I think it's safe to ignore those two for now.
I would expand the list to all or almost all common widows executables. You can find many lists online, this was the first hit for me: https://www.howtogeek.com/137270/50-file-extensions-that-are-potentially-dangerous-on-windows/ There are a bunch of executables for linux/mac, but viruses for these are basically nonexistent, since it's very hard to do anything without necessary permissions. For example, you can't even run an executable without giving it explicit execute permission. So I think it's safe to ignore those two for now.
updated the list for windows file extensions
Could u please improve ur PR description and also add some screenshots of all the dialogs please? Thanks
sure i posted the 2 scenarios with the listener 😄
auto merging this on the weekend if no approves come in sooner 👍
Mhm yes thanks
I would expand the list to all or almost all common widows executables. You can find many lists online, this was the first hit for me: https://www.howtogeek.com/137270/50-file-extensions-that-are-potentially-dangerous-on-windows/
There are a bunch of executables for linux/mac, but viruses for these are basically nonexistent, since it's very hard to do anything without necessary permissions. For example, you can't even run an executable without giving it explicit execute permission. So I think it's safe to ignore those two for now.
---- On Sat, 27 Aug 2022 17:25:53 +0200 Mom0aut @.***> wrote ---
Close https://github.com/Together-Java/TJ-Bot/issues/484
The config was slightly changed, the following was added:
Config
The config was slightly changed, the following was added:
"blacklistedFileExtension": "memes"
You can view, comment on, or merge this pull request online at:
https://github.com/Together-Java/TJ-Bot/pull/542
Commit Summary
https://github.com/Together-Java/TJ-Bot/pull/542/commits/141d7f0ffb1dd1a82aff07ef153c7aa5c427a82b added AttachmentListener checks if the message attachment contains blacklisted file extensions
File Changes (https://github.com/Together-Java/TJ-Bot/pull/542/files) M https://github.com/Together-Java/TJ-Bot/pull/542/files#diff-d3cb91974a7018defe0e196080ec8b2f1b84f41f3f721cf342cbd1e447979044 (6)
M https://github.com/Together-Java/TJ-Bot/pull/542/files#diff-bbb936fdbe5b13be4e475be331c0eb388b91d272edefde3eadd9b0f05bcb0374 (7)
A https://github.com/Together-Java/TJ-Bot/pull/542/files#diff-5622eb60ab6e2791703abee0922301ef3832fd318b90ff1f472910b3de44b417 (126)
M https://github.com/Together-Java/TJ-Bot/pull/542/files#diff-0ce547862f0b6a4f2c9ce5b51c2ea5f58cf909e207b5ebfe19f92ddd5e7f1101 (17)
Patch Links:
https://github.com/Together-Java/TJ-Bot/pull/542.patch
https://github.com/Together-Java/TJ-Bot/pull/542.diff
— Reply to this email directly, https://github.com/Together-Java/TJ-Bot/pull/542, or https://github.com/notifications/unsubscribe-auth/AHL6YWJMPDWIETFKCPQYKJ3V3IXQDANCNFSM57ZPPTDA. You are receiving this because your review was requested.
arent these already in the list? note that we kept some out to not hinder UX (jar, pdf)