Timothy Mothra

Results 154 comments of Timothy Mothra

Converting to draft so this doesn't merge. Need to get clarification on the requirements.

@cijothomas, I'm interested in working on this. I stumbled into a repro of this issue.

Sharing my notes here so we can have a discussion next week. ## For Context The following test demonstrates the issue. In this example, the `InMemoryExporter.Export` will add `Metric`s to...

Questions: - Are we committed to deep-copying Metric? - Can we change the behavior of InMemoryExporter for Metrics only? ### Regarding deep-copy Metric The original suggestion was to deep-copy the...

## Update Discussed this issue in the 2/22/2022 meeting. - Will clear collection in exporter. - Will update [doc](https://github.com/open-telemetry/opentelemetry-dotnet/tree/main/docs/metrics/extending-the-sdk) with description of change in behavior. Users will be expected to...

> // would this affect what has already been exported (since the point is reused)? No, working with the `Counter` doesn't affect the `Metric` nor `MetricPoint` until calling `ForceFlush`. The...

## Update Discussed this issue in the 3/22/2022 meeting. - Will abandon any code changes in favor of doc updates - Will update - extending-the-sdk Readme - InMemoryExporter Readme -...

Per conversation in https://github.com/open-telemetry/opentelemetry-dotnet/pull/3071#discussion_r834603581 - I'm going to use the doc PR (#3071) to update the extending-the-sdk guide. - will focus on an approach to clone the exported metrics. We...

@cijothomas In your PR, what was the reason for using `#if NETSTANDARD2_1_OR_GREATER || NETCOREAPP3_1_OR_GREATER` instead of just `#if NETSTANDARD2_1_OR_GREATER` ? I would have expected the single to work, I'm curious...