Tim M

Results 72 comments of Tim M
trafficstars

At a glance the get DateTimeOffset optimisation might apply. My vectorized decode CrockfordBase32 is faster than the manual version, with some slight modifications (currently turns invalid characters into 31) it...

## Blake #### Beforehand - non Itrinsics version (with reduced memory usage) ![image](https://user-images.githubusercontent.com/49349513/196801425-57c59f1d-37ab-4b11-a2ce-89fe4be42eff.png) #### Intrinsics refactor d90f3a6 ![image](https://user-images.githubusercontent.com/49349513/196801468-b8b2fa52-8c7d-440d-a8f0-da2ca045e96a.png) #### Using code from @saucecontrol [Blake2Fast](https://github.com/saucecontrol/Blake2Fast) ![image](https://user-images.githubusercontent.com/49349513/196801502-5f1ef415-6007-4bb2-afb6-9d072d432f75.png) Adapted Blake2bSimd to use intrinsics...

Glad you liked it! 😄 `ModifiedBlake2Intrinsics` was largely done at 2 AM, it the passes the test but I have no idea if it safe. I'm sure the performance can...

Added the PHC compress function. It passes the tests but the old hacky version appears to be faster? ### Hacky version | Method | Job | EnvironmentVariables | Iterations |...

> I think that if I'm reading the numbers right, they're pretty much the same? Which is what I would sort of expect. The implementations actually seem roughly the same...

Hey, could you share a minimal reproduction of this issue? I haven't been able to reproduce in a modern ASP project. I'm guessing your issue is related to this line...

I think this is intentional, no? It would be strange if `ApiResponse.IsSuccessStatusCode` returned `false` when the actual `HttpResponseMessage` was successful. Instead I think `ApiResponse` should have the property `IsSuccess`. This...

Thanks 😊, you're welcome to make a pr. Otherwise I'll get around to it tomorrow 😅 Might be worth updating the `NotNullWhen` attributes to use it, see #1303

> I'm wondering if it's worth updating the documentation at https://github.com/reactiveui/refit#handling-exceptions Yeah, good idea. I feel like most usage of `IsSuccessStatusCode` could be replaced with `IsSuccess`. On an related note...

Rebased and done some modifications. Added `Refit.UnreachableException` for cases that should not be able to happen. Not sure what I'm missing but bizarrely the benchmarks don't show a major change...