node-ytpl icon indicating copy to clipboard operation
node-ytpl copied to clipboard

Separation of the 'validateID' method into 3 methods: 'validateID', 'validateURL' and 'validate'

Open theo-bnts opened this issue 4 years ago • 4 comments

I think this makes the methods more consistent. Let me know if you need further changes.

theo-bnts avatar Sep 16 '21 12:09 theo-bnts

This pull request introduces 2 alerts when merging e5aefabf83f52610dd1280249cde5faf1d39c35c into fcc26a1c4bd569bfa397c8ca5735d02949220a62 - view on LGTM.com

new alerts:

  • 2 for Missing exports qualifier

lgtm-com[bot] avatar Sep 16 '21 12:09 lgtm-com[bot]

i can see how this simplifies the code but i do not see the advantage of exposing all 3 methods 🤔 from what i experienced it will confuse people

these minor changes would also require a major release since they change the behaviour of the already defined validateID func

TimeForANinja avatar Oct 17 '21 02:10 TimeForANinja

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Dec 16 '21 14:12 stale[bot]

Codecov Report

Merging #123 (fcc26a1) into master (fcc26a1) will not change coverage. The diff coverage is n/a.

:exclamation: Current head fcc26a1 differs from pull request most recent head fc75447. Consider uploading reports for the commit fc75447 to get more accurate results Impacted file tree graph

@@            Coverage Diff            @@
##            master      #123   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines          260       260           
=========================================
  Hits           260       260           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fcc26a1...fc75447. Read the comment docs.

codecov[bot] avatar Jan 30 '22 18:01 codecov[bot]