TOSplitViewController
TOSplitViewController copied to clipboard
Hiding Primary Column & Forwarding Interface Style Traits
Hiding Primary Column
Adds the following properties:
primaryColumnIsHiddencollapseAnimationDuration
Example has been updated to include the above demonstration.
Trait Collection Overrides
When overriding the trait collections, the userInterfaceStyle is also appended to the composite trait collection.
I have made some changes to the example with respect setting background colours using the new system colours for the demo. This may be undesirable and can be reverted via an additional commit if necessary.
This should resolve https://github.com/TimOliver/TOSplitViewController/issues/4
Hi @dezinezync!
Oh wow! You actually got it working! Amazing! I'm really impressed! Fantastic work!
Just one little nitpick. It would probably be a bit nicer for the library to continue supporting versions of iOS below 13. Can you please go back and annotate all of the colors to only swap to the semantic colouring when on iOS 13? (The sample app can stay at requiring iOS 13. That's fine)
Thanks!
@TimOliver Done. I also took the opportunity to ensure user interface style trait code is only called on iOS 13 to prevent crashes on older versions.
I’ve tried this pull request in my existing project but user interface style changes are still only being reflected in the detail view controller, am i missing something? It works fine in the example project so assuming I am.
@joekw Are you overriding traits from any other controllers? Perhaps third party code? The project I am using this in does not, so forwarding from this works just fine for me for all child view controllers.
@dezinezync Not completely sure what i was doing wrong but redid my TOSplitViewController setup and now it’s working, thanks!!