TOCropViewController icon indicating copy to clipboard operation
TOCropViewController copied to clipboard

Mac OS Catalyst Support

Open iDevid opened this issue 5 years ago • 12 comments
trafficstars

Is your feature request related to a problem? Please describe. This future request relates to Mac OS Catalyst introduction during this WWDC19.

Describe the solution you'd like Fully support to Mac OS Catalyst

Describe alternatives you've considered

Additional context

iDevid avatar Nov 29 '19 22:11 iDevid

What does it need to support Catalina exactly?

TimOliver avatar Nov 30 '19 04:11 TimOliver

Any news for this issue? is there a workaround for using this pod with Catalyst?

itayAmza avatar Jan 02 '20 08:01 itayAmza

Um, no? I still have no idea what is needed to support Catalyst.

Can someone please explain what’s going on?

I‘m sorry, but I’m future it looks like I need to be far more strict on issues that don’t follow the issue guidelines I request in submitting zero useable information.

@iDevid Please outline what the main issues are for supporting Catalyst within 24 hours, or I’m closing this issue.

TimOliver avatar Jan 02 '20 09:01 TimOliver

Actually seems that the real problem is due to CocoaPods. CocoaPods Issue

iDevid avatar Jan 02 '20 09:01 iDevid

Ohhh. Wow! Okay, thanks for clarifying!

I'll take a look at it! Thanks for that! :)

TimOliver avatar Jan 02 '20 10:01 TimOliver

@TimOliver any new version expected soon?

itayAmza avatar Jan 08 '20 09:01 itayAmza

@itayAmza Nope, no new versions at the moment. Sorry!

I don't have any need for Catalyst support for the time being in my current project so this is super low priority for me.

If you specifically need Catalyst support, you can consider filing a PR, but it looks like this is a CocoaPods-side issue for the time being, so there might not be anything we can do for now.

TimOliver avatar Jan 08 '20 10:01 TimOliver

Easy fix for now based on @chrisballinger response

post_install do |installer|
    installer.pods_project.targets.each do |target|
        target.build_configurations.each do |config|
            ##Fix TOCropViewController code sign issue for macCatalyst
            if target.name == "TOCropViewController-TOCropViewControllerBundle"
              puts "Adding #{target.name} development team"
              config.build_settings['DEVELOPMENT_TEAM'] = 'XXXXXX'
            end
        end
    end
end

itayAmza avatar Jan 14 '20 10:01 itayAmza

Cool! Glad you were able to find a work-around that ended up working for you!

From the sound of it, there’s nothing I can do to fix this on my end except pray that Xcode 12 will fix it.

I’ll leave this issue open for now. I’ll add a notice in the README to explain this workaround and then close it.

TimOliver avatar Jan 19 '20 04:01 TimOliver

That fix works for building it, but to submit to appstore i get the same error

masaldana2 avatar May 30 '20 09:05 masaldana2

I've been playing with a Mac Catalyst app and ran into the same issue with other libraries now. It seems any CocoaPods packages that contain any kind of resources (images, language strings etc) is having this problem.

HOPEFULLY Apple will have added ways to fix this in the next version of Xcode, but until then, we're kinda at the mercy of CocoaPods themselves to engineer a workaround.

TimOliver avatar May 30 '20 12:05 TimOliver

I installed it manually, added the bridge header and the delivery to the appstore was successful for now

masaldana2 avatar May 30 '20 18:05 masaldana2