django-multi-form-view icon indicating copy to clipboard operation
django-multi-form-view copied to clipboard

Get context data from superclass

Open DorkmasterFlek opened this issue 5 years ago • 1 comments
trafficstars

Original implementation did not call super().get_context_data so extra context data from superclasses and other mix-ins was lost. This appeared to be in order to avoid the issue of the regular FormView class trying to get a singular form class since MultiFormView was subclassed from it, but this can be avoided by setting the "form" field in kwargs to None if it's not present instead. This keeps the extra context data intact and conforms to other Django context mix-in classes.

DorkmasterFlek avatar Dec 01 '19 18:12 DorkmasterFlek

Codecov Report

Merging #12 into master will not change coverage. The diff coverage is 75%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #12   +/-   ##
=======================================
  Coverage   97.26%   97.26%           
=======================================
  Files          18       18           
  Lines         293      293           
=======================================
  Hits          285      285           
  Misses          8        8
Impacted Files Coverage Δ
multi_form_view/base.py 87.5% <75%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d7f0a34...8e9e1dc. Read the comment docs.

codecov-io avatar Dec 01 '19 18:12 codecov-io