TileDB icon indicating copy to clipboard operation
TileDB copied to clipboard

Move FragmentMetadata::tile_offsets to new fragment OndemandMetadata

Open robertbindar opened this issue 1 year ago • 1 comments

Move FragmentMetadata::tile_offsets_ to new fragment OndemandMetadata.

Kept it as simple as possible so we get early feedback and potentially merge individual work pieces:

  • This PR is moving only tile_offsets, the intent is to move all lazily loaded metadata.
  • Once we move all offsets, we can also move loaded_metadata_ mappings to be managed by OndemandMetadata
  • The more we move there, the less parent_fragment_ like accesses we'll have, right now there are plenty so I can get an individually mergeable piece.
  • Would it be possible we get rid of the LoadedMetadata mappings altogether and model optionality with std::optional?
  • I don't really see why tile_offsets_mtx_ and mtx_ are needed, it'd be nice if they turn out to be redundant old code.

TYPE: NO_HISTORY | IMPROVEMENT DESC: Move FragmentMetadata::tile_offsets to new fragment OndemandMetadata

robertbindar avatar Apr 03 '24 14:04 robertbindar