TileDB
TileDB copied to clipboard
TileDB-Inc
Scope array consistency to a context.
Previously this was scoped to a process which breaks the REST server.
TYPE: IMPROVEMENT DESC: Scope array consistency to a context.
@ypatia says she's unblocked on this work... @davisp is this PR still required?
@ypatia says she's unblocked on this work... @davisp is this PR still required?
It wasn't ever required. I just saw the chatter and discovered that the consistency controller looked easy enough to swap to context specific instead of process specific so I took a quick stab at it. As far as I'm concerned, passing the checks proves it is easy enough which is all I intended for this PR.
I'm more than fine closing this if we don't want to include this work in this release cycle which is more than understandable. It was only about 30m of work and more than half of that was reading the code to figure out how it worked to begin with.
This would slightly reduce the utility of the consistency feature, for the case where multiple contexts are being used.
How about we add instead a config option named like sm.enable_consistency that allows entirely bypassing the consistency controller when opening an array?
This would slightly reduce the utility of the consistency feature, for the case where multiple contexts are being used.
The problem originated from an issue on cloud where we very much don't want multiple independent contexts interfering with each other. But this was only a learning exercise so not really a big deal either way at the moment. It just might be something we have to look at harder in the future. Adding a config value in the future might be a possibility if we decide the current behavior is useful for something.