TileDB icon indicating copy to clipboard operation
TileDB copied to clipboard

Remove duplicate ASAN linker option.

Open teo-tsirpanis opened this issue 1 year ago • 5 comments

See https://github.com/TileDB-Inc/TileDB/pull/4515#pullrequestreview-1791109390


TYPE: BUILD DESC: Remove duplicate ASAN linker option.

teo-tsirpanis avatar Jan 12 '24 19:01 teo-tsirpanis

Can we move the greater ASAN validation work to a separate PR and just merge this one? For ease of review, the linker option is already being globally set here: https://github.com/TileDB-Inc/TileDB/blob/e11fe82e3ff17da4454522b782b0450c64c6e7b5/cmake/Modules/Sanitizer.cmake#L73

teo-tsirpanis avatar Feb 14 '24 12:02 teo-tsirpanis

@teo-tsirpanis Let's update the title of this PR and the description to describe what you are trying to accomplish here.

KiterLuc avatar Feb 16 '24 06:02 KiterLuc

@KiterLuc done.

teo-tsirpanis avatar Feb 16 '24 09:02 teo-tsirpanis

Closing for now. We don't have time to implement proper testing for this at the moment and we have tracking items for this in shortcut.

KiterLuc avatar Feb 27 '24 08:02 KiterLuc