TileDB icon indicating copy to clipboard operation
TileDB copied to clipboard

Published 20 hours ago • verified publisher icon TileDB-Inc

Always use vcpkg.

Open teo-tsirpanis opened this issue 1 year ago • 1 comments

[!NOTE] Blocked by TileDB-Inc/tiledb-feedstock#7.

SC-36911

This PR changes the severity of the message when we configure with -DTILEDB_VCPKG=OFF from a DEPRECATION to a FATAL_ERROR. This means that using the legacy ExternalProject-based mechanism for acquiring dependencies is no longer supported. The ExternalProject modules have become dead code and will be removed in a subsequent PR.

TYPE: BUILD DESC: Vcpkg is always enabled; turning the TILEDB_VCPKG option off is no longer supported and fails.

teo-tsirpanis avatar Dec 11 '23 20:12 teo-tsirpanis

This pull request has been linked to Shortcut Story #36911: Remove "enable vcpkg" options from CMake command line and bootstrap scripts.

shortcut-integration[bot] avatar Dec 11 '23 20:12 shortcut-integration[bot]

With conda-forge/tiledb-feedstock#242 being merged, there are no first-party projects that disable vcpkg. This PR can be merged.

teo-tsirpanis avatar Mar 08 '24 16:03 teo-tsirpanis

@ihnorton there is already this snippet. What else should I add? https://github.com/TileDB-Inc/TileDB/blob/cab84bc230a29dee5699c1c96f9dd84559bcaea4/doc/dev/BUILD.md?plain=1#L131-L136

teo-tsirpanis avatar Apr 02 '24 17:04 teo-tsirpanis