TileDB icon indicating copy to clipboard operation
TileDB copied to clipboard

Bugfix: deserialize array_schema_all_ into array object

Open ypatia opened this issue 3 years ago • 1 comments
trafficstars

#2844 introduced a new Cap'n'p object for Array class that is serializing among others array_schema_all_ field.

However, #2923 introduced a regression by removing (by mistake?) the line that sets the array_schema_all_ field on the Array object during deserialization. Unfortunately, the array serialization unit test wasn't checking if this field is properly set, hence the regression.

NOTE: The new array open serialization code is not used at the moment so this is not a bug in production

I enhanced the existing Array serialization UT to check for the deserialized array_schema but not for array_schema_all_ as I'd like so that we have a regression test. The reason is that we currently don't have a C API to retrieve all the array_schemas list if I am not mistaken. Open to ideas on how to proceed.


TYPE: IMPROVEMENT DESC: Fix deserialize to set array_schema_all_ into array object

ypatia avatar Jul 12 '22 10:07 ypatia