TileDB-Py icon indicating copy to clipboard operation
TileDB-Py copied to clipboard

Return empty result for invalid enumeration

Open nguyenv opened this issue 1 year ago • 2 comments
trafficstars

https://github.com/TileDB-Inc/TileDB-Py/issues/1880

Note that we already supported comparison operators on ordered enumerated values

As requested by @bkmartinjr

nguyenv avatar Dec 15 '23 21:12 nguyenv

This is also needs to be ported over to TileDB-SOMA-Py.

nguyenv avatar Dec 15 '23 21:12 nguyenv

[sc-43002]

After discussing with @kounelisagis, we are just going to use this pre-existing PR to add the unit tests instead of opening a new one.

nguyenv avatar Mar 14 '24 15:03 nguyenv

Error comes from libtiledb. Should we address it there?

FAILED tiledb/tests/test_query_condition.py::QueryConditionTest::test_qc_enumeration - tiledb.cc.TileDBError: TileDB internal: Enumeration value not found for field 'attr2'

kounelisagis avatar Mar 15 '24 10:03 kounelisagis

We need to wait for the libtiledb 2.21.0 release for this fix and then we can update setup.py. Although in the meantime we can test this against 2.21.0-rc2 to make sure CI is all passing.

nguyenv avatar Mar 15 '24 12:03 nguyenv

@kounelisagis I'm so sorry, when I rebased against main and force pushed I accidentally removed your commits. Can you push your changes again?

nguyenv avatar Mar 15 '24 17:03 nguyenv

It fails without 2.21 (or at least with 2.20...)


git checkout viviannguyen/sc-38443/dataframe-value-filter-on-enum-dict-column
pip install -r requirements_dev.txt
python setup.py develop
python -c "import tiledb; print(tiledb.libtiledb.version())"

(2, 21, 0)

pytest -o log_cli=true --log-cli-level=10 tiledb/tests/test_query_condition.py

Passes


git checkout dev setup.py
python setup.py develop
python -c "import tiledb; print(tiledb.libtiledb.version())"

(2, 20, 1)

pytest -o log_cli=true --log-cli-level=10 tiledb/tests/test_query_condition.py

Gives the following error: https://gist.github.com/kounelisagis/7c9d8803b24f92335b2c71d58bc7f9c8

kounelisagis avatar Mar 21 '24 09:03 kounelisagis

Also tested it with 2.21.0 (not pre-release) and it works.

kounelisagis avatar Mar 21 '24 09:03 kounelisagis

Thanks for doing the work of double checking @kounelisagis.

nguyenv avatar Mar 21 '24 15:03 nguyenv

And also for reverting the libtiledb version in setup.py.

nguyenv avatar Mar 21 '24 15:03 nguyenv