WebGrid icon indicating copy to clipboard operation
WebGrid copied to clipboard

Readiness probes of some components not correct

Open TilBlechschmidt opened this issue 3 years ago • 1 comments

🐛 Bug description

It appears that some components do not propagate the correct readiness probe state regarding connectivity to the Redis server. It seems to be affecting the manager, orchestrator, and gangway. The collector and api probably suffer the same issue but in the observed scenario they kept on crashing because the mongodb server was unavailable.

🦶 Reproduction steps

Steps to reproduce the behavior:

  1. Deploy a webgrid fresh
  2. Make sure the redis and/or MongoDB don't come up
  3. Watch it burn 🔥

🎯 Expected behaviour

This is more of a philosophical discussion on whether the software should crash upon encountering an error or just report a negative readiness state. Probably the latter, however, even that is currently not given. Redis connectivity should be reflected in the readiness state!

📺 Screenshots

image

TilBlechschmidt avatar Dec 07 '21 13:12 TilBlechschmidt

image After giving it a few minutes to settle down, it appears as though the api and collector crash (as expected), the gangway correctly report the readiness, and the manager and orchestrator behave incorrectly.

TilBlechschmidt avatar Dec 07 '21 13:12 TilBlechschmidt