File operations with folders in path

[mpolano]

Hi Sébastien,

I hope I've correctly interpreted your intention for the URL encoding. Now all file functions accept a file_path that includes folders like "test-folder/dataset.csv" and each function takes care of URL encoding appropriately.

In order to make it work I've also modified gl_file_list() adding a parameter to specify the path. This requires on the API call to add a query parameter (as documented here).

I found what I think is a bug in gl_file_exists() that I've fixed: looking for files in an empty repository produced an error.

I have added tests to take into account folders trying to follow what you already did without folders.

[statnmap]

Thanks. I'll test it in a few days, when back from holidays :smiley:

[statnmap]

Less than 2 years to achieve this one...
This was a big one, and I am happy to close it :) Thank you for your nice contribution!
I retrieved all your commit in this PR: https://github.com/ThinkR-open/gitlabr/pull/106

[mpolano]

It's never too late 🙂. I'm glad to have contributed to this project.

Keep up the good work !

On Tue, 14 May 2024 at 16:58, Sébastien Rochette @.***> wrote:

Less than 2 years to achieve this one... This was a big one, and I am happy to close it :) Thank you for your nice contribution! I retrieved all your commit in this PR: #106 https://github.com/ThinkR-open/gitlabr/pull/106

— Reply to this email directly, view it on GitHub https://github.com/ThinkR-open/gitlabr/pull/74#issuecomment-2110466326, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEGGYN5IMLCQZORB35HPHDTZCIRCLAVCNFSM57TX2FJ2U5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TEMJRGA2DMNRTGI3A . You are receiving this because you authored the thread.Message ID: @.***>