Adrian

Considering that this is just a plugin API where there's a good chance nobody else will use it anytime soon, I'd be OK with merging this as-is for now. I'll...

While testing I noticed another problem: when no core fields are changed, the Reservation.modify method exits early so the signal never gets called. So I'm starting to wonder whether it...

something like this could also work: ```py if changes: # the usual logging here elif 'extra_data' not in data: return ``` that way we'd avoid creating empty log entries (if...

but i'm wondering why you changes work at all :D the default when using a marshmallow schema for processing request data is to ignore any unknown fields, and you did...

Ah I see, you patch the core schema from your plugin, that's why it works. ```py CreateBookingSchema._declared_fields['extra_fields'] = mm.fields.Nested( schemas.ReservationExtraFieldsSchema, required=False, allow_none=True, ) ``` It also means that the core...

Could you rebase it and fix the conflicts?

Maybe the SurveyLinkPlaceholder could be changed similar to the `EventLinkPlaceholder` so it allows setting a custom link text as well?

You do not need to ask for permission to work on an issue. If you think you can contribute this, please simply go ahead.

Here's some useful context from our internal chat around that topic which you may find useful: > it's almost a one-liner > i just tested and calling `printReceipts({registration_id: [123456], event_id:...

Just send a PR if you're interested.