lorawan-devices icon indicating copy to clipboard operation
lorawan-devices copied to clipboard

Edit Senzemo Folder

Open vzmvc opened this issue 1 year ago • 4 comments

Summary

Updated our data with new webpage links, new vendors and added new sensors.

Changes

  • Changed URLs to products and datasheets
  • Added new sensors (STO10, STP40, STF40, SSM40)

Checklist for Reviewers

  • [ ] Title and description should be descriptive (Not just a serial number for example).
  • [ ] profileIDs should not be vendorID and should be a unique value for every profile.
  • [ ] All devices should be listed in the vendor's index.yaml file.
  • [ ] Firmware versions can not be changed.
  • [ ] At least 1 image per device and should be transparent.

Notes for Reviewers

...

Release Notes

  • ...

vzmvc avatar Aug 06 '24 13:08 vzmvc

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Aug 06 '24 13:08 CLAassistant

Hi @vzmvc there are some changes to do, in your resellers regions please put European Union in all UK, Germany, Austria, for the moment that is the only acceptable value. Also in the sensors please use the sensors that are on the list, if the sensors are not in the list please put it commented to the validation pass.

Jaime-Trinidad avatar Sep 09 '24 12:09 Jaime-Trinidad

To add to this, please look at the example file. It will show in the comments which values are valid.

https://github.com/TheThingsNetwork/lorawan-devices/blob/ffa8efa86cc2332aedd472de82aa8a394aad779e/vendor/example/windsensor.yaml#L68-L75

https://github.com/TheThingsNetwork/lorawan-devices/blob/473777a23a33741bbe87baf10b3767214c8db93f/vendor/example/windsensor.yaml#L155-L156

Note we just added a PR for adding the United Kingdom to the list of valid values so make sure that you have updated your branch.

LDannijs avatar Sep 09 '24 12:09 LDannijs

Hi @vzmvc please check the files, there are errors in the images extensions, in sensor arrays, if you are not adding sensors for the moment, please comment #sensors:

Jaime-Trinidad avatar Sep 20 '24 13:09 Jaime-Trinidad

@Jaime-Trinidad Is the problem with the images because of jpg? Those were there before. Do i have to change them to png?

vzmvc avatar Oct 24 '24 07:10 vzmvc