lorawan-devices icon indicating copy to clipboard operation
lorawan-devices copied to clipboard

Initial commit for Cors System Organisation

Open patientenvy opened this issue 1 year ago • 8 comments

Summary

...

Changes

  • Added cortu-genesis 2 device

Checklist for Reviewers

  • [ ] Title and description should be descriptive (Not just a serial number for example).
  • [ ] profileIDs should not be vendorID and should be a unique value for every profile.
  • [ ] All devices should be listed in the vendor's index.yaml file.
  • [ ] Firmware versions can not be changed.
  • [ ] At least 1 image per device and should be transparent.

Notes for Reviewers

...

Release Notes

  • ...

patientenvy avatar Jul 15 '24 15:07 patientenvy

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

:white_check_mark: cors-oreoluwa
:white_check_mark: patientenvy
:x: Aceallio
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Jul 15 '24 15:07 CLAassistant

@patientenvy Files look good now, could you please still run make validate fmt? (apologies for being so late, i was on vacation :)

LDannijs avatar Aug 12 '24 07:08 LDannijs

I have run the make validate fmt and it worked but it seems like there is a problem with github check format. It runs perfectly locally on my computer problem ptest

CorsInterns avatar Aug 26 '24 16:08 CorsInterns

Could you please run make validate fmt specifically? Our validation is specifically made for our repo.

LDannijs avatar Aug 27 '24 07:08 LDannijs

I have reverted the package files

CorsInterns avatar Aug 27 '24 16:08 CorsInterns

CLA assistant check Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 3 committers have signed the CLA.✅ patientenvy❌ cors-oreoluwa❌ AceallioYou have signed the CLA already but the status is still pending? Let us recheck it.

Also, please sign our CLA..

LDannijs avatar Aug 28 '24 15:08 LDannijs

@Aceallio could you sign the CLA still?

LDannijs avatar Sep 09 '24 12:09 LDannijs

@Aceallio Any update here? Could you please sign the CLA?

LDannijs avatar Sep 24 '24 07:09 LDannijs

Hi @patientenvy due the time I will close this PR, feel free to open it again or create a new one.

Jaime-Trinidad avatar Jan 28 '25 13:01 Jaime-Trinidad