Evan Sharp

Results 116 comments of Evan Sharp

@AdamJessop It turns out that if I don't actually update the dist files, then no one gets them :( lol.. yeah, I forgot to run gulp to create the dist...

Per socket.io, the config's query must be a string, which is why it's limited to a string here. Yes, it would be nice to handle an object for the dev...

Sure, this can be an optional prop, when `mountOnEnter` is `true` it will mount and unmount the component based on the visibility of the tab. For now the workaround is...

@jomarquez21 isn't that what this issue is asking for? Have the component mount and thus "activate" the `componentDidMount` life-cycle when it becomes active (when the activeTab is equal to the...

You can apply classNames to the various elements you want to target (or just to the wrapper and target your styles via nesting (`.className > div > div`)). // Apply...

> This handles an issue where the aria-hidden attribute is considered invalid by automated tools that check for WCAG compliance. Is there a specific WCAG test number it is failing?...

> Can I still use react-router-bootstrap with reactstrap? No, react-router-bootstrap solves an issue for react-bootstrap which reactstrap solved with the `tag` prop. As for the issue of "the dropdown toggles...

This would be an enhancement, which means when you create the commit, you'll use [conventional commits](https://conventionalcommits.org/#do-all-my-contributors-need-to-use-the-conventional-commit-specification) messages which starts with something like "feat(Dropdown): " in this case. You don't need...

you could iterating over the children (recessively since children will contain a menu which has the actual items) to determine if any of them are "active". Note: React have methods...

It's kinda half done. Right now when you have a child they is active the parent will be active with the inheritActive prop. But it will not automatically make the...