Legendary-Java-Minecraft-Geyser-Floodgate icon indicating copy to clipboard operation
Legendary-Java-Minecraft-Geyser-Floodgate copied to clipboard

Fix for ViaVersion autoupdate code

Open Yankie opened this issue 1 year ago • 1 comments

Fixes #34

Yankie avatar Sep 12 '24 16:09 Yankie

Can confirm the proposed fix results in retrieving the version properly:

❯ curl --no-progress-meter -k -L -H "Accept-Encoding: identity" -H "Accept-Language: en" -L -A "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/90.0.4.212 Safari/537.36" https://ci.viaversion.com/job/ViaVersion/lastBuild/artifact/build/libs/ | grep -P '(?<=href=")ViaVersion[^"]+' -o --max-count=1 | head -n1
ViaVersion-5.0.4-SNAPSHOT.jar

cyberops7 avatar Sep 21 '24 02:09 cyberops7

It would be great to see this get merged so that the standard docker run command in the repo readme would work again!

tunafishman avatar Oct 24 '24 20:10 tunafishman

Accepted, thank you!

TheRemote avatar Dec 01 '24 18:12 TheRemote