Martin

Results 89 comments of Martin
trafficstars

I think this is acceptable for a new Java release. We just shouldn't backport it. Do you really think anybody sets one of these flags in production? Are you aware...

Breaks AIX build: os_aix.cpp:1626:5: error: unknown type name 'ErrorPreserver'; did you mean 'ErrnoPreserver'? New test is failing on linux PPC64le: TestMemoryAllocationLogging.java#testUncommitFailed ``` exitValue = 139 java.lang.RuntimeException: Expected to get exit...

Do you need more than the System.err output? ``` stdout: [[0.002s][debug][os,map] Reserved [0x00007fffb1960000 - 0x00007fffb1970000), (65536 bytes) [0.002s][debug][os,map] Committed [0x00007fffb1960000 - 0x00007fffb1970000), (65536 bytes) [0.004s][debug][os,map] Committed [0x00007fffaec10000 - 0x00007fffaec40000), (196608...

The build issue is resolved. Thanks. However, the tests are still failing: linux ppc64le: ``` stdout: [[0.003s][debug][os,map] Reserved [0x00007fff8c9b0000 - 0x00007fff8c9c0000), (65536 bytes) [0.003s][debug][os,map] Committed [0x00007fff8c9b0000 - 0x00007fff8c9c0000), (65536 bytes)...

Thanks for the update! The failures on PPC64 are gone.

I think we shouldn't allow `MacroAssembler::string_compress(...)` and `MacroAssembler::string_expand(...)` to use vector registers without specifying this effect. That can be solved by adding a KILL effect for all vector registers which...

> > I think we shouldn't allow `MacroAssembler::string_compress(...)` and `MacroAssembler::string_expand(...)` to use vector registers without specifying this effect. That can be solved by adding a KILL effect for all vector...

> @TheRealMDoerr and @RealLucy Just for my understanding why GPR and FPR doesn't get affected in intrinsic code as they are also allocated outside of register allocator? why only vector...